Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more documentation for the instrumentor base class #638

Merged
merged 7 commits into from
May 12, 2020
Merged

Add more documentation for the instrumentor base class #638

merged 7 commits into from
May 12, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 2, 2020

Fixes #637

@ocelotl ocelotl added doc Documentation-related instrumentation Related to the instrumentation of third party libraries or frameworks labels May 2, 2020
@ocelotl ocelotl requested a review from a team May 2, 2020 00:53
@ocelotl ocelotl self-assigned this May 2, 2020
toumorokoshi
toumorokoshi suggested changes May 3, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! There's a couple areas I think that could be rewritten to be a bit more succinct, see comments.

opentelemetry-auto-instrumentation/src/opentelemetry/auto_instrumentation/instrumentor.py Outdated Show resolved Hide resolved
opentelemetry-auto-instrumentation/src/opentelemetry/auto_instrumentation/instrumentor.py Outdated Show resolved Hide resolved
opentelemetry-auto-instrumentation/src/opentelemetry/auto_instrumentation/instrumentor.py Outdated Show resolved Hide resolved
@ocelotl ocelotl requested a review from toumorokoshi May 5, 2020 15:25
toumorokoshi
toumorokoshi approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codeboten codeboten merged commit e84faa4 into open-telemetry:master May 12, 2020
owais pushed a commit to owais/opentelemetry-python that referenced this pull request May 22, 2020
@ocelotl @toumorokoshi
@c24t @owais
docs: Add more documentation for the instrumentor base class (open-te…
ae88315 
…lemetry#638)

Fixes open-telemetry#637

Co-authored-by: Yusuke Tsutsumi <[email protected]>
Co-authored-by: Chris Kleinknecht <[email protected]>
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@cthulhu-bot @mayurkale22
chore: rename Metric Handle to Bound Instrument (open-telemetry#634) (o…
6f0084f 
…pen-telemetry#638)

* chore: fix renames in metrics test

* chore: fix formatting

* chore: rename BaseInstrument to BaseBoundInstrument

Co-authored-by: Mayur Kale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@lzchen lzchen lzchen approved these changes

@c24t c24t c24t approved these changes

Assignees

@ocelotl ocelotl

Labels
doc Documentation-related instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the instrumentation documentation
5 participants
@ocelotl @toumorokoshi @lzchen @c24t @codeboten