Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoinstrumentation docs #544

Merged
merged 3 commits into from
May 6, 2020
Merged

Fix autoinstrumentation docs #544

merged 3 commits into from
May 6, 2020

Conversation

mauriciovasquezbernal
Copy link
Member

Two small fixes for autoinstrumentation docs.

@mauriciovasquezbernal mauriciovasquezbernal requested a review from a team April 3, 2020 14:05
@mauriciovasquezbernal mauriciovasquezbernal changed the title Fix auinstrumentation docs Fix autoinstrumentation docs Apr 3, 2020
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little feedback on the guide itself, and curious about eliminating some of the examples since they're a little redundant. with other docs we have.

docs/examples/auto-instrumentation/README.rst Outdated Show resolved Hide resolved
docs/examples/auto-instrumentation/README.rst Outdated Show resolved Hide resolved
docs/examples/auto-instrumentation/README.rst Show resolved Hide resolved
@mauriciovasquezbernal
Copy link
Member Author

I'll wait for a decision on #547 before performing further updates to this PR.

@mauriciovasquezbernal mauriciovasquezbernal added the doc Documentation-related label Apr 7, 2020
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit with a couple fixes and one update that takes #567 into consideration, feel free to take it into consideration, @mauriciovasquezbernal 👍

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it is now 👍


As you can see, both outputs are equivalent since the automatic
instrumentation does what the manual instrumentation does too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add more advanced uses cases here? For example passing in configuration arguments in instrument.

- Convert file to rst to be included in the generated documentation
- Include docs for main module.
- Use internal reference instead of read the docs link
@mauriciovasquezbernal
Copy link
Member Author

I wanted to fix this as part of #547, but that will take longer than expected. Given that:

I'd propose to merge this PR that is just changing the file format + fixing some small issues.

Further modifications to the content itself could be done in follow up PRs. @toumorokoshi what do you think?

Btw, I got so many conflicts that I decided to start from scratch and force pushed to this PR.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toumorokoshi toumorokoshi merged commit 0889895 into open-telemetry:master May 6, 2020
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request May 8, 2020
- Convert file to rst to be included in the generated documentation
- Include docs for main module.
- Use internal reference instead of read the docs link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants