Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Correlation Context API and propagator #471
Adding Correlation Context API and propagator #471
Changes from 19 commits
4d595f8
764ee23
868987d
b2bf9d5
13ddb5c
bba033e
b6fc6cf
495c840
2a732f7
8449360
2e813af
778d8f4
1bc5a83
270ddc2
54ac2cc
2c5d20f
19342ce
09617ef
4fd969f
39192ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The draft of the W3C Correlation Context specification has some limits on the header: https://w3c.github.io/correlation-context/#header-value. Are those checks missing on purpose here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they were not, added them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be nice to have a function that receives a list (or dict) of key-value peers and adds them to the correlation context at once. It'll avoid to create that many temporal contexts that are overwritten in the next iteration of the loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree, there was nothing in the spec for this but it could definitely be something we implement.
This file was deleted.