-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tracecontext integration test gitref #4448
Conversation
|
7f797a5
to
4d6f519
Compare
Apologies this is my first PR - tests were passing locally but are failing in CI with tox.
Option 2 works with:
Guidance would be appreciated - I can follow up with whatever is recommended. |
How tests passed locally? |
91903b8
to
c4d2f03
Compare
Update gitref to latest from https://github.com/w3c/trace-context Skip changed test that is incompatible with our implementation Add fixme comment to track setting flags for the test suite when they are available
c4d2f03
to
91c3114
Compare
Description
We're currently using an outdated version of the W3C test, this results in warnings in CI.
Updated gitref in
scripts/tracecontext-integration-test.sh
to latest from wc3/trace-context.Skipped changed test that is incompatible with our implementation (we drop duplicated keys which is optional in the spec).
Added fixme comment to track setting flags for the test suite when they are available (wc3 issue)
Fixes #4105
Closes #4109
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: