Exclude attributes without stability from stable semconv part #4391
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
approved these changes
Jan 22, 2025
trentm
reviewed
Jan 22, 2025
| @@ -13,7 +13,7 @@ templates: | |||
| filter: > | |||
| semconv_grouped_attributes({ | |||
| "exclude_root_namespace": $excluded_namespaces, | |||
| "exclude_stability": if $filter == "any" then [] else ["experimental"] end, | |||
| "exclude_stability": if $filter == "any" then [] else ["experimental", "", null] end, | |||
There was a problem hiding this comment.
Should the same be done for the exclude_stability below for pattern: semantic_metrics.j2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/semantic-conventions#1777
Semconv should not have attributes without stability, but this one slipped in.
We'll fix it in semconv and also enforce it better to prevent this in the future - open-telemetry/semantic-conventions#1781, but let's exclude attributes without stability from the stable part.
Since semconv artifact is at
0.50b0, I assume it's allowed to have breaking changes?This attribute is not used by anything in OTel python, was introduced in prev version of semconv and I'm suggesting to drop it.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: