Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused assertEqualSpanInstrumentationInfo #4310

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Remove unused assertEqualSpanInstrumentationInfo #4310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e5bd34
Remove assertEqualSpanInstrumentationInfo
tammy-baylis-swi Nov 22, 2024
f56346c
Changelog
tammy-baylis-swi Nov 22, 2024
6d62fd1
Merge branch 'main' into rm-assertequal-instrinfo
tammy-baylis-swi Nov 22, 2024
11d987b
Merge branch 'main' into rm-assertequal-instrinfo
tammy-baylis-swi Nov 25, 2024
53fefaa
Update CHANGELOG.md
tammy-baylis-swi Nov 26, 2024
8612c21
Merge branch 'main' into rm-assertequal-instrinfo
tammy-baylis-swi Nov 26, 2024
e0a5f05
Merge branch 'main' into rm-assertequal-instrinfo
lzchen Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#4311](https://github.com/open-telemetry/opentelemetry-python/pull/4311))
- sdk: fix serialization of logs severity_number field to int
([#4324](https://github.com/open-telemetry/opentelemetry-python/pull/4324))
- Remove `TestBase.assertEqualSpanInstrumentationInfo` method, use `assertEqualSpanInstrumentationScope` instead
([#4310](https://github.com/open-telemetry/opentelemetry-python/pull/4310))

## Version 1.28.0/0.49b0 (2024-11-05)

Expand Down
4 changes: 0 additions & 4 deletions tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ def get_finished_spans(self):
self, self.memory_exporter.get_finished_spans()
)

def assertEqualSpanInstrumentationInfo(self, span, module):
self.assertEqual(span.instrumentation_info.name, module.__name__)
self.assertEqual(span.instrumentation_info.version, module.__version__)

def assertEqualSpanInstrumentationScope(self, span, module):
self.assertEqual(span.instrumentation_scope.name, module.__name__)
self.assertEqual(
Expand Down