Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated shutdown() calls in sdk metrics tests as it can be called once #4188

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Remove duplicated shutdown() calls in sdk metrics tests as it can be called once #4188

merged 2 commits into from
Sep 18, 2024

Conversation

Ali-Alnosairi
Copy link
Contributor

@Ali-Alnosairi Ali-Alnosairi commented Sep 13, 2024 •
edited by emdneto
Loading

Description

Fixes #4187

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Ali-Alnosairi Ali-Alnosairi requested a review from a team September 13, 2024 19:23
@Ali-Alnosairi
Copy link
Contributor Author

Ali-Alnosairi commented Sep 13, 2024 •
edited
Loading

@xrmx , @emdneto , @lzchen
would you please review this PR!

@lzchen lzchen mentioned this pull request Sep 16, 2024
Open
@Ali-Alnosairi
Copy link
Contributor Author

@ocelotl
Does changelog need to be updated ?

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 16, 2024
@lzchen lzchen merged commit 6919f65 into open-telemetry:main Sep 18, 2024
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen left review comments

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove one shutdown() calls in test_synchronous_delta_temporality() as shutdown() can only be called once
4 participants
@Ali-Alnosairi @ocelotl @lzchen @emdneto