-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running mypy on SDK resources (following up #3995) #4053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit
|
|
asasvari
force-pushed
the
pr3995
branch
2 times, most recently
from
July 13, 2024 10:59
a8bce5a
to
82a980b
Compare
Part of open-telemetry#1608 Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
asasvari
changed the title
Do not merge: this is just to re-test PR 3995
Running mypy on SDK resources (following up #3995)
Jul 13, 2024
I performed more testing locally PASS
FAIL
|
xrmx
reviewed
Jul 14, 2024
Co-authored-by: Riccardo Magliocchetti <[email protected]>
Co-authored-by: Riccardo Magliocchetti <[email protected]>
xrmx
reviewed
Jul 14, 2024
Co-authored-by: Riccardo Magliocchetti <[email protected]>
Co-authored-by: Riccardo Magliocchetti <[email protected]>
Co-authored-by: Riccardo Magliocchetti <[email protected]>
tox mypy finds 4 errors for
|
xrmx
reviewed
Jul 19, 2024
aabmass
reviewed
Jul 19, 2024
xrmx
reviewed
Jul 25, 2024
xrmx
added
Skip Changelog
PRs that do not require a CHANGELOG.md entry
and removed
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Jul 25, 2024
@asasvari Please also add a Changelog entry to a new Unreleased section |
@asasvari Please rebase to fix CHANGELOG conflicts |
xrmx
reviewed
Jul 26, 2024
xrmx
approved these changes
Jul 26, 2024
xrmx
reviewed
Jul 30, 2024
lzchen
approved these changes
Jul 30, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #3995
Quoting Medinat Lawal:
Part of #1608
Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
Type of change
How Has This Been Tested?
tox -e mypy
tox -e test-opentelemetry-sdk
tox -e test-opentelemetry-api
async_context.py
,basic_trace.py
,logs/example.py
) using local changesChecklist: