Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change imports to avoid pylint namespace errors #376

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Change imports to avoid pylint namespace errors #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec0fbe
Revert "Revert import changes to shim"
c24t Jan 23, 2020
01619bc
Use pylint ignore directives instead
c24t Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ext/opentelemetry-ext-opentracing-shim/src/opentelemetry/ext/opentracing_shim/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@
https://docs.python.org/3/tutorial/floatingpoint.html
"""

# TODO: make pylint use 3p opentracing module for type inference
# pylint:disable=no-member

import logging

import opentracing
Expand Down Expand Up @@ -266,7 +269,7 @@ def log(self, **kwargs):
def log_event(self, event, payload=None):
super().log_event(event, payload=payload)

def set_baggage_item(self, key, value):
def set_baggage_item(self, key, value): # pylint:disable=unused-argument
"""Implements the ``set_baggage_item()`` method from the base class.

Warning:
Expand All @@ -279,7 +282,7 @@ def set_baggage_item(self, key, value):
)
# TODO: Implement.

def get_baggage_item(self, key):
def get_baggage_item(self, key): # pylint:disable=unused-argument
"""Implements the ``get_baggage_item()`` method from the base class.

Warning:
Expand Down
3 changes: 3 additions & 0 deletions ext/opentelemetry-ext-opentracing-shim/tests/test_shim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# TODO: make pylint use 3p opentracing module for type inference
# pylint:disable=no-member

import time
from unittest import TestCase

Expand Down