Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing sem conv value for cloud.resource_id #3394

Conversation

jeremydvoss
Copy link
Contributor

Description

Adding missing field from cloud sem conv

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jeremydvoss jeremydvoss force-pushed the cloud-resource-id-sem-conv branch from 9f25c1a to e87e910 Compare July 28, 2023 00:27
@jeremydvoss jeremydvoss marked this pull request as ready for review July 28, 2023 00:27
@jeremydvoss jeremydvoss requested a review from a team July 28, 2023 00:27
@srikanthccv
Copy link
Member

The files in opentelemetry-semantic-conventions are auto-generated by a script. If something is missing, it means the current generated version is old. The right thing to do is bump the semantic convention version, thanks to @lmolkova for #3251 which updates the semconv

@jeremydvoss
Copy link
Contributor Author

The files in opentelemetry-semantic-conventions are auto-generated by a script....

Understood. Will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants