-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds None check for backoff.expo() iteration #2970
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog entry
7c4ddc2
to
2b35996
Compare
I think you actually just want to do a check for none, then continue. The next value in expo will be one: >>> import backoff
>>> for v in backoff.expo(max_value=64):
... print(v)
... if v == 64:
... break
...
1
2
4
8
16
32
64
>>> for v backoff v2 >>> from backoff import expo
>>> for v in expo(max_value=64):
... print(v)
... if v == 64:
... break
...
None
1
2
4
8
16
32
64
>>> |
@ElementalWarrior Thanks for the suggestion, updated. |
Addressed in #2980 so I am going to close this. |
Description
Periodic back off in exporter is broken. Full description in issue #2829.
Fixes #2829
Type of change
How Has This Been Tested?
Tests Suite
Recreate and fix locally
poetry install && poetry run uvicorn main:app
opentelemetry-exporter-otlp-proto-grpc = { path = "$HOME/.../opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-grpc" }
poetry lock && poetry install --sync && poetry run uvicorn main:app
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: