-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre and post instrument entrypoints #1983
Conversation
be75fcd
to
70dabd7
Compare
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @owais made a good point in the SIG. Should we make this PR additive of the new entry points only and put a comment that opentelemetry_distro
entrypoint is deprecated?
Could you also add some documentation on the opentelemetry-{pre,post}-instrument
entry points since this is general purpose and anyone can use it. Maybe some of the figures from the slides you presented too?
...etry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/sitecustomize.py
Outdated
Show resolved
Hide resolved
I don't intend to deprecate |
@ocelotl I'm totally onboard with this PR. I was only suggesting we make this change gradually by keeping the distro hook as is for now and only adding pre/post hooks as new hooks. Once the configurator package you are working on that will provide distro hooks is ready and published, we can remove the distro hook from this package. It's still the same design as you presented but will be done in may be one additional PR. |
Refactored this PR to only include the entry points |
We need changelog for this. |
added it 👍 |
Fixes #1982