-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove service name #1669
Remove service name #1669
Conversation
…y-python into remove_service_name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmarar Thanks for picking this up. I believe we should also remove the OTEL_PYTHON_SERVICE_NAME
and service name in auto instrumentation.
exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_protobuf.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_thrift.py
Outdated
Show resolved
Hide resolved
Thanks @lonewolf3739 . Will work on this. |
exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/__init__.py
Outdated
Show resolved
Hide resolved
...lemetry-exporter-opencensus/src/opentelemetry/exporter/opencensus/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
modified distro and distro tests to get service_name from Resouce
…y-python into remove_service_name
…y-python into remove_service_name
…elemetry-python into remove_service_name
My mistake, I thought you meant it was ALREADY removed prior to this PR. Ignore my comment :) |
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_thrift.py
Show resolved
Hide resolved
@owais I'm not able to add you as 3rd reviewer. I have made the changes you suggested. |
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_protobuf.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
@owais can you confirm your comments have been addressed |
Changes from #1669 have not been reflected in the docs
Description
The service-name parameter from the constructors of exporters of Opencensus, jaeger was removed.
Instead the Resource's service.name attribute from Tracer/Span was used to get the service_name
Fixes # (issue)
#1607
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
opentelemetry-instrumentation/
have changedThe method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: