Add convenience methods to access common config options in Configuration class #1426
Conversation
srikanthccv
requested review from
a team,
owais and
codeboten
and removed request for
a team
.github/workflows/test.yml
Outdated
| @@ -10,7 +10,7 @@ env: | |||
| # Otherwise, set variable to the commit of your branch on | |||
| # opentelemetry-python-contrib which is compatible with these Core repo | |||
| # changes. | |||
| CONTRIB_REPO_SHA: bcec49cf2eccf8da66c9e63b9836ea8a20516efc | |||
| CONTRIB_REPO_SHA: 61ae201677be80e333746f06bc9485fa8856f42c | |||
There was a problem hiding this comment.
Updated to show that tests pass, will revert once approved.
There was a problem hiding this comment.
As soon as your Contrib repo PR gets merged, you can't revert this. It either has to be master or this commit. I think leaving it as this commit is fine so that you don't have to change anything!
There was a problem hiding this comment.
I thought the flow was supposed to be the reverse i.e, core repo gets merged first and then contrib.
| @@ -167,3 +179,20 @@ def _reset(cls) -> None: | |||
| if cls._instance: | |||
| cls._instance._config_map.clear() # pylint: disable=protected-access | |||
| cls._instance = None | |||
|
|
|||
| def traced_request_attrs(self, instrumentation: str) -> List[str]: | |||
There was a problem hiding this comment.
Nit: Can you make these protected? I believe we are only using these internally.
There was a problem hiding this comment.
Yeah sure. I was thinking we would let users use this if they need.
|
|
||
| def _excluded_urls(self, instrumentation: str) -> ExcludeList: | ||
| key = "{}_EXCLUDED_URLS".format(instrumentation.upper()) | ||
| value = self._config_map.get(key, "") |
There was a problem hiding this comment.
I'm not sure if commas are allowed in URLs, but they can appear meaningfully in a regex like \d{5,10}. This seems more like an issue with passing comma separated regexes in envars than this PR though.
There was a problem hiding this comment.
Comma is reserved character and is not typically used in URLs. It is normally used in query component for name value pairs.
Co-authored-by: Aaron Abbott <[email protected]>
Description
Fixes #1217
Type of change
Does This PR Require a Contrib Repo Change?