-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast PyMongo commands as strings #1015
Cast PyMongo commands as strings #1015
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. It looks like the CLA still needs to be signed. It would be good to add a test validating the TypeError no longer occurs after the change.
Thanks for the feedback. I need my CLA manager to approve, but I can write that test in the mean time. |
@DrMcTaco any update on getting the CLA signed? |
This has been fixed in #1132 |
Description
Cast the pymongo
command
as a string when starting spans for pymongo events. When thegetMore
action is executed thecommand
is anint
.Fixes #1012
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
querying a mongo collection for records when the batch size is less than the total number of records to be returned, e.g:
Also ran the
tox
test suite.Checklist: