Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/grpc: Implement BaseInstrumentor interface #661

Closed
codeboten opened this issue May 8, 2020 · 2 comments · Fixed by #788
Closed

ext/grpc: Implement BaseInstrumentor interface #661

codeboten opened this issue May 8, 2020 · 2 comments · Fixed by #788
Assignees
@aravinsiva
Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@codeboten
Copy link
Contributor

In order for users of grpc to take advantage of opentelemetry-auto-instrumentation, the following needs to happen:

  1. add a class implementing the BaseInstrumentor interface. here is an example for ext/pymysql
  2. an entrypoint must be added to setup.cfg. here is an example for ext/pymsql
  3. tests added to ensure the new instrumentor behaves as expected. here is an example for ext/pymysql
  4. the documentation must be updated to reflect the new method of instrumenting psycopg2 applications
  5. CHANGELOG.md must be updated
@codeboten codeboten added good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks labels May 8, 2020
@aravinsiva
Copy link
Contributor

I would be happy to look into this.

@codeboten
Copy link
Contributor Author

Thanks @aravinsiva, assigned it to you

@aravinsiva aravinsiva mentioned this issue Jun 17, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22 @dyladan
Release process (open-telemetry#661)
0ad90e7 
* chore: update RELEASING.md

* chore: update RELEASING.md

* chore: add known issue

Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aravinsiva aravinsiva

Labels
good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding gRPC instrumentor aravinsiva/opentelemetry-python
2 participants
@codeboten @aravinsiva