Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release handle/bound instrument in metrics from memory upon direct metric calling convention #399

Closed
lzchen opened this issue Feb 6, 2020 · 0 comments · Fixed by #435
Closed

Release handle/bound instrument in metrics from memory upon direct metric calling convention #399

lzchen opened this issue Feb 6, 2020 · 0 comments · Fixed by #435
Assignees
@mauriciovasquezbernal
Labels
enhancement New feature or request good first issue Good first issue metrics

Comments

@lzchen
Copy link
Contributor

lzchen commented Feb 6, 2020 •
edited
Loading

Metric handles are stored in memory upon creation. We need to have a way of releasing that memory.

Upon direct metric calling convention, the handles used for these operations should be released according to the specs.
@lzchen lzchen added enhancement New feature or request metrics labels Feb 6, 2020
@lzchen lzchen mentioned this issue Feb 6, 2020
Merged
@lzchen lzchen changed the title Release handle/bound instrument in metrics from memory Release handle/bound instrument in metrics from memory upon direct metric calling convention Feb 7, 2020
@lzchen lzchen added the good first issue Good first issue label Feb 7, 2020
@mauriciovasquezbernal mauriciovasquezbernal self-assigned this Feb 19, 2020
Merged
@c24t c24t closed this as completed in #435 Mar 17, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore: add HTTPS to default instrumented plugins list (open-telemetry…
88c2e85 
…#399)

* chore: add HTTPS to default instrumented plugins list

* fix: update node-sdk README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriciovasquezbernal mauriciovasquezbernal

Labels
enhancement New feature or request good first issue Good first issue metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metrics: add possibility to release handles and observer instruments kinvolk/opentelemetry-python
2 participants
@lzchen @mauriciovasquezbernal