Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask/WSGI Ignore Tracing Specific Endpoints #353

Closed
disfluxly opened this issue Jan 3, 2020 · 4 comments
Closed

Flask/WSGI Ignore Tracing Specific Endpoints #353

disfluxly opened this issue Jan 3, 2020 · 4 comments
Labels
enhancement New feature or request instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@disfluxly
Copy link
Contributor

Describe the solution you'd like
Include a decorator or configuration setting that toggles tracing for requests against a specific endpoint. Given a Flask Application that sits behind a Load Balancer where the LB checks a /status endpoint every couple of seconds, this quickly leads to a large number of traces against that endpoint (especially when you have 100 of these tasks...). It would be cleaner, and save network/storage cost, if we could disable tracing against specific endpoints such as this.

@toumorokoshi toumorokoshi added the enhancement New feature or request label Jan 14, 2020
@toumorokoshi
Copy link
Member

This seems like a good option. I wonder if there's something more general in the opentelemetry-specification around this.Do you have thoughts on what an API for that configuration might look like?

We'll discuss this at our next SIG meeting as well.

@disfluxly
Copy link
Contributor Author

From a code perspective, it would be nice to have a decorator that would be used to specify that the following route be trace-ignored. In addition, there would also need to be a mechanism to access the route api directly to set an ignore on routes created by third-party libraries, such as https://github.com/Runscope/healthcheck

@disfluxly
Copy link
Contributor Author

@toumorokoshi - Curious, how did the SIG meeting go?

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@codeboten codeboten added the instrumentation Related to the instrumentation of third party libraries or frameworks label Nov 6, 2020
@lzchen lzchen closed this as completed Nov 9, 2020
@lzchen
Copy link
Contributor

lzchen commented Nov 9, 2020

Closed with #565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Development

No branches or pull requests

4 participants