-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flaky and pytest-benchmark installations to scripts/eachdist.py develop #2772
Comments
Update regarding the tests not working on Windows. It actually seems to be an issue with the new version of googleap-common-protos and protobuf. The good news is I don't think it's OS-dependent because I was able to reproduce the error on Ubuntu. The bad news is that means both Windows and Linux are broken with the new Google package. Will make a new issue soon for that specific issue soon |
@jeremydvoss |
Yes. Or, more ideally, the script should be updated. |
I would rather remove eachdist from development setup entirely. I never had to use it. |
I agree, we should not mention it in contributing documentation. |
Fixes #2772 Co-authored-by: Srikanth Chekuri <[email protected]>
Describe your environment Python 3.10. Linux and Windows.
Steps to reproduce
Follow CONTRIBUTING steps on a clean environment. Upon running the "scripts/eachdist.py test" script, notice that flaky needs to be installed. "pip install flaky" and run the tests again. Notice that pytest-benchmark needs to be installed. "pip install pytest-benchmark" then run tests again. They pass (albeit with some warnings) on linux. I am personally still facing issues on Windows.
What is the expected behavior?
After running "scripts/eachdist.py test", "scripts/eachdist.py test" should pass without any missing modules.
What is the actual behavior?
Instead, I get the following before installing flaky:
After installing flaky, I get the following before installing pytest-benchmark:
Additional context
As noted above, I think there is still some work needed to make the CONTRIBUTING document fully applicable to Windows. It seems to me that following the instructions on Windows is yields yet another issue that I am still investigating.
The text was updated successfully, but these errors were encountered: