-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify prev point is returned for cumulative readers instead of None #2755
Comments
I am a bit confused, what is a "cumulative reader"? Is it an arbitrary designation or can we find out if a |
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
Jun 21, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
Jun 21, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
Jun 27, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
Jun 30, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
Jun 30, 2022
ocelotl
added a commit
that referenced
this issue
Jun 30, 2022
* Verify previous point is returned for cumulative instruments Fixes #2755 * Reject non-cumulative temporalities for Prometheus metric reader * Add test case for InMemoryMetricReader * Fix prometheus import paths * Remove parameters for Prometheus init * Add sleep for windows tests * Add temporality overriding dictionary
Repository owner
moved this from In Review
to Done
in Python Metrics RC2
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This LGTM. For cumulative readers though, we need to make sure they return the previous point value instead of None. For example, with a prometheus exporter:
Do you know if that is the case? If not we should open another issue for rc2.
Originally posted by @aabmass in #2745 (review)
The text was updated successfully, but these errors were encountered: