Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsRecording becomes false after End #1243

Closed
codeboten opened this issue Oct 15, 2020 · 0 comments
Closed

IsRecording becomes false after End #1243

codeboten opened this issue Oct 15, 2020 · 0 comments
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per the spec change here: open-telemetry/opentelemetry-specification@ec58e45

Note: is_recording should be set after calling on_end in the span processor
@codeboten codeboten added release:required-for-ga To be resolved before GA release good first issue Good first issue help wanted labels Oct 15, 2020
robwknox added a commit to robwknox/opentelemetry-python that referenced this issue Oct 23, 2020
@robwknox
Span.is_recording() returns false after end() has been called (open-t…
671ffdc 
…elemetry#1243)
robwknox added a commit to robwknox/opentelemetry-python that referenced this issue Oct 23, 2020
@robwknox
linter recommended reformat (open-telemetry#1243)
378344a
@robwknox robwknox mentioned this issue Oct 23, 2020
Closed
6 tasks
robwknox added a commit to robwknox/opentelemetry-python that referenced this issue Oct 26, 2020
@robwknox
Changing internal is_recording checks to use ._is_recording vs is_rec…
e68bc24 
…ording() (open-telemetry#1243)
robwknox added a commit to robwknox/opentelemetry-python that referenced this issue Oct 26, 2020
@robwknox
Adding changelog entry (open-telemetry#1243)
3be20f8
robwknox referenced this issue Oct 27, 2020
addressing concurrency issue in Span API (#1259)
27dc691 
Before this change, the following would cause unintended behaviour in the Span API's add_event, update_name and set_status methods:

- thread A calls set_status, locks to check if a span has ended, and releases the lock
- thread B obtains the lock and ends a span
- thread A continues its call of set_status

This change ensures that the update operations are done with the lock being held. It's done in a decorator, but that is completely optional.
robwknox added a commit to robwknox/opentelemetry-python that referenced this issue Oct 27, 2020
@robwknox
Merge master tweak (open-telemetry#1243)
44990c0
@robwknox robwknox mentioned this issue Oct 27, 2020
Merged
5 tasks
@lzchen lzchen assigned lzchen and unassigned lzchen Oct 29, 2020
@lzchen lzchen closed this as completed Oct 29, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
Nominate @obecny as maintainer (open-telemetry#1243)
dbe2e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @lzchen