Make explicit_bucket_boundaries_advisory kwargs only

open-telemetry · Jan 27, 2025 · d4dc7c6 · d4dc7c6
1 parent 32be722
commit d4dc7c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py b/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py
@@ -430,6 +430,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
+        *,
         explicit_bucket_boundaries_advisory: Optional[Sequence[float]] = None,
     ) -> Histogram:
         """Creates a :class:`~opentelemetry.metrics.Histogram` instrument
@@ -578,6 +579,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
+        *,
         explicit_bucket_boundaries_advisory: Optional[Sequence[float]] = None,
     ) -> Histogram:
         with self._lock:
@@ -586,7 +588,7 @@ def create_histogram(
                     name,
                     unit,
                     description,
-                    explicit_bucket_boundaries_advisory,
+                    explicit_bucket_boundaries_advisory=explicit_bucket_boundaries_advisory,
                 )
             proxy = _ProxyHistogram(
                 name, unit, description, explicit_bucket_boundaries_advisory
@@ -743,6 +745,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
+        *,
         explicit_bucket_boundaries_advisory: Optional[Sequence[float]] = None,
     ) -> Histogram:
         """Returns a no-op Histogram."""

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py
@@ -199,6 +199,7 @@ def create_histogram(
         name: str,
         unit: str = "",
         description: str = "",
+        *,
         explicit_bucket_boundaries_advisory: Optional[Sequence[float]] = None,
     ) -> APIHistogram:
         if explicit_bucket_boundaries_advisory is not None: