Span.is_recording() now based off self._end_time and returns False if… (

#1289)
open-telemetry · Oct 29, 2020 · bcc53c8 · bcc53c8
1 parent f3cdfa2
commit bcc53c8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/opentelemetry-sdk/CHANGELOG.md b/opentelemetry-sdk/CHANGELOG.md
@@ -10,7 +10,10 @@
   ([#998](https://github.com/open-telemetry/opentelemetry-python/pull/998))
 - Samplers to accept parent Context
   ([#1267](https://github.com/open-telemetry/opentelemetry-python/pull/1267))
-- Updating status codes to adhere to spec ([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
+- Updating status codes to adhere to spec
+  ([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
+- Span.is_recording() returns false after span has ended
+  ([#1289](https://github.com/open-telemetry/opentelemetry-python/pull/1289))
 
 ## Version 0.14b0
 

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -646,7 +646,7 @@ def update_name(self, name: str) -> None:
         self.name = name
 
     def is_recording(self) -> bool:
-        return True
+        return self._end_time is None
 
     @_check_span_ended
     def set_status(self, status: trace_api.Status) -> None: