Exempt resource attributes from span limits (#2138)

open-telemetry · Sep 25, 2021 · b2d5ab3 · b2d5ab3
1 parent 3cee4ef
commit b2d5ab3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,8 +20,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#2101](https://github.com/open-telemetry/opentelemetry-python/pull/2101))
 - Fix incorrect headers parsing via environment variables
   ([#2103](https://github.com/open-telemetry/opentelemetry-python/pull/2103))
+- Attribute limits no longer apply to Resource attributes
+  ([#2138](https://github.com/open-telemetry/opentelemetry-python/pull/2138))
 - `opentelemetry-exporter-otlp`: Add `opentelemetry-otlp-proto-http` as dependency
-- ([#2147](https://github.com/open-telemetry/opentelemetry-python/pull/2147))
+  ([#2147](https://github.com/open-telemetry/opentelemetry-python/pull/2147))
 
 ## [1.5.0-0.24b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.5.0-0.24b0) - 2021-08-26
 

diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -1069,11 +1069,6 @@ def __init__(
         self._span_limits = span_limits or SpanLimits()
         self._atexit_handler = None
 
-        self._resource._attributes = BoundedAttributes(
-            self._span_limits.max_attributes,
-            self._resource._attributes,
-            max_value_len=self._span_limits.max_attribute_length,
-        )
         if shutdown_on_exit:
             self._atexit_handler = atexit.register(self.shutdown)
 

diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -1490,7 +1490,6 @@ def test_dropped_attributes(self):
         self.assertEqual(3, span.dropped_events)
         self.assertEqual(2, span.events[0].attributes.dropped)
         self.assertEqual(2, span.links[0].attributes.dropped)
-        self.assertEqual(2, span.resource.attributes.dropped)
 
     def _test_span_limits(
         self,