Skip to content

Commit

Permalink
Exempt resource attributes from span limits
Browse files Browse the repository at this point in the history
  • Loading branch information
owais committed Sep 22, 2021
1 parent 8b5a967 commit 6fee7da
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,11 +1069,6 @@ def __init__(
self._span_limits = span_limits or SpanLimits()
self._atexit_handler = None

self._resource._attributes = BoundedAttributes(
self._span_limits.max_attributes,
self._resource._attributes,
max_value_len=self._span_limits.max_attribute_length,
)
if shutdown_on_exit:
self._atexit_handler = atexit.register(self.shutdown)

Expand Down
1 change: 0 additions & 1 deletion opentelemetry-sdk/tests/trace/test_trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,6 @@ def test_dropped_attributes(self):
self.assertEqual(3, span.dropped_events)
self.assertEqual(2, span.events[0].attributes.dropped)
self.assertEqual(2, span.links[0].attributes.dropped)
self.assertEqual(2, span.resource.attributes.dropped)

def _test_span_limits(
self,
Expand Down

0 comments on commit 6fee7da

Please sign in to comment.