Update instrumentation/opentelemetry-instrumentation-tornado/tests/te…

…st_instrumentation.py

Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>

instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py

@@ -165,9 +165,11 @@ def process_request(self, req, resp):
         if not span:
             return
 
-        attributes = extract_attributes_from_object(req, self._traced_request_attrs)
+        attributes = extract_attributes_from_object(
+            req, self._traced_request_attrs
+        )
         for key, value in attributes.items():
-            span.set_attribute(key, str(value))
+            span.set_attribute(key, value)
 
     def process_resource(self, req, resp, resource, params):
         span = req.env.get(_ENVIRON_SPAN_KEY)

instrumentation/opentelemetry-instrumentation-tornado/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Added support for `OTEL_PYTHON_TORNADO_TRACED_REQUEST_ATTRS` ([#1178](https://github.com/open-telemetry/opentelemetry-python/pull/1178))
+
 ## Version 0.13b0
 
 Released 2020-09-17

instrumentation/opentelemetry-instrumentation-tornado/README.rst

@@ -40,7 +40,7 @@ For example,
 
 ::
 
-    export OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS='uri,query'
+    export OTEL_PYTHON_TORNADO_TRACED_REQUEST_ATTRS='uri,query'
 
 will extract path_info and content_type attributes from every traced request and add them as span attributes.
 

instrumentation/opentelemetry-instrumentation-tornado/tests/test_instrumentation.py

@@ -362,10 +362,10 @@ def test_traced_attrs(self):
         self.fetch("/ping?q=abc&b=123")
         spans = self.sorted_spans(self.memory_exporter.get_finished_spans())
         self.assertEqual(len(spans), 2)
-        server = spans[0]
-        self.assertEqual(server.kind, SpanKind.SERVER)
+        server_span = spans[0]
+        self.assertEqual(server_span.kind, SpanKind.SERVER)
         self.assert_span_has_attributes(
-            server, {"uri": "/ping?q=abc&b=123", "query": "q=abc&b=123"}
+            server_span, {"uri": "/ping?q=abc&b=123", "query": "q=abc&b=123"}
         )
         self.memory_exporter.clear()