tests(exporters): zipkin/json, zipkin/proto/http, oltp/proto/http

open-telemetry · Jun 28, 2022 · 5bf5f0e · 5bf5f0e
1 parent 85cd4ec
commit 5bf5f0e
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_log_exporter.py b/exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_log_exporter.py
@@ -18,6 +18,8 @@
 from typing import List, Tuple
 from unittest.mock import patch
 
+import requests
+
 from opentelemetry.exporter.otlp.proto.http import Compression
 from opentelemetry.exporter.otlp.proto.http._log_exporter import (
     DEFAULT_COMPRESSION,
@@ -81,6 +83,7 @@ def test_constructor_default(self):
         self.assertEqual(exporter._timeout, DEFAULT_TIMEOUT)
         self.assertIs(exporter._compression, DEFAULT_COMPRESSION)
         self.assertEqual(exporter._headers, {})
+        self.assertIsInstance(exporter._session, requests.Session)
 
     @patch.dict(
         "os.environ",
@@ -99,6 +102,7 @@ def test_exporter_constructor_take_priority(self):
             headers={"testHeader1": "value1", "testHeader2": "value2"},
             timeout=70,
             compression=Compression.NoCompression,
+            session=requests.Session(),
         )
 
         self.assertEqual(exporter._endpoint, "endpoint.local:69/logs")
@@ -109,6 +113,7 @@ def test_exporter_constructor_take_priority(self):
             exporter._headers,
             {"testHeader1": "value1", "testHeader2": "value2"},
         )
+        self.assertIsInstance(exporter._session, requests.Session)
 
     @patch.dict(
         "os.environ",
@@ -133,6 +138,7 @@ def test_exporter_env(self):
         self.assertEqual(
             exporter._headers, {"envheader1": "val1", "envheader2": "val2"}
         )
+        self.assertIsInstance(exporter._session, requests.Session)
 
     def test_encode(self):
         sdk_logs, expected_encoding = self.get_test_logs()

diff --git a/exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_span_exporter.py b/exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_span_exporter.py
@@ -15,6 +15,8 @@
 import unittest
 from unittest.mock import patch
 
+import requests
+
 from opentelemetry.exporter.otlp.proto.http import Compression
 from opentelemetry.exporter.otlp.proto.http.trace_exporter import (
     DEFAULT_COMPRESSION,
@@ -55,6 +57,7 @@ def test_constructor_default(self):
         self.assertEqual(exporter._timeout, DEFAULT_TIMEOUT)
         self.assertIs(exporter._compression, DEFAULT_COMPRESSION)
         self.assertEqual(exporter._headers, {})
+        self.assertIsInstance(exporter._session, requests.Session)
 
     @patch.dict(
         "os.environ",
@@ -86,6 +89,7 @@ def test_exporter_traces_env_take_priority(self):
                 "traceenv3": "==val3==",
             },
         )
+        self.assertIsInstance(exporter._session, requests.Session)
 
     @patch.dict(
         "os.environ",
@@ -105,6 +109,7 @@ def test_exporter_constructor_take_priority(self):
             headers={"testHeader1": "value1", "testHeader2": "value2"},
             timeout=20,
             compression=Compression.NoCompression,
+            session=requests.Session(),
         )
 
         self.assertEqual(exporter._endpoint, "example.com/1234")
@@ -115,6 +120,7 @@ def test_exporter_constructor_take_priority(self):
             exporter._headers,
             {"testHeader1": "value1", "testHeader2": "value2"},
         )
+        self.assertIsInstance(exporter._session, requests.Session)
 
     @patch.dict(
         "os.environ",

diff --git a/exporter/opentelemetry-exporter-zipkin-json/tests/test_zipkin_exporter.py b/exporter/opentelemetry-exporter-zipkin-json/tests/test_zipkin_exporter.py
@@ -17,6 +17,8 @@
 import unittest
 from unittest.mock import patch
 
+import requests
+
 from opentelemetry import trace
 from opentelemetry.exporter.zipkin.encoder import Protocol
 from opentelemetry.exporter.zipkin.json import DEFAULT_ENDPOINT, ZipkinExporter
@@ -55,6 +57,7 @@ def tearDown(self):
     def test_constructor_default(self):
         exporter = ZipkinExporter()
         self.assertIsInstance(exporter.encoder, JsonV2Encoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, DEFAULT_ENDPOINT)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(exporter.local_node.ipv4, None)
@@ -83,6 +86,7 @@ def test_constructor_protocol_endpoint(self):
         exporter = ZipkinExporter(endpoint=endpoint)
 
         self.assertIsInstance(exporter.encoder, JsonV2Encoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, endpoint)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(exporter.local_node.ipv4, None)
@@ -104,6 +108,7 @@ def test_constructor_all_params_and_env_vars(self):
         local_node_port = 30301
         max_tag_value_length = 56
         timeout_param = 20
+        session_param = requests.Session()
 
         exporter = ZipkinExporter(
             constructor_param_version,
@@ -113,9 +118,11 @@ def test_constructor_all_params_and_env_vars(self):
             local_node_port,
             max_tag_value_length,
             timeout_param,
+            session_param,
         )
 
         self.assertIsInstance(exporter.encoder, JsonV2Encoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, constructor_param_endpoint)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(

diff --git a/exporter/opentelemetry-exporter-zipkin-proto-http/tests/test_zipkin_exporter.py b/exporter/opentelemetry-exporter-zipkin-proto-http/tests/test_zipkin_exporter.py
@@ -17,6 +17,8 @@
 import unittest
 from unittest.mock import patch
 
+import requests
+
 from opentelemetry import trace
 from opentelemetry.exporter.zipkin.node_endpoint import NodeEndpoint
 from opentelemetry.exporter.zipkin.proto.http import (
@@ -57,6 +59,7 @@ def tearDown(self):
     def test_constructor_default(self):
         exporter = ZipkinExporter()
         self.assertIsInstance(exporter.encoder, ProtobufEncoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, DEFAULT_ENDPOINT)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(exporter.local_node.ipv4, None)
@@ -85,6 +88,7 @@ def test_constructor_protocol_endpoint(self):
         exporter = ZipkinExporter(endpoint)
 
         self.assertIsInstance(exporter.encoder, ProtobufEncoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, endpoint)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(exporter.local_node.ipv4, None)
@@ -105,6 +109,7 @@ def test_constructor_all_params_and_env_vars(self):
         local_node_port = 30301
         max_tag_value_length = 56
         timeout_param = 20
+        session_param = requests.Session()
 
         exporter = ZipkinExporter(
             constructor_param_endpoint,
@@ -113,9 +118,11 @@ def test_constructor_all_params_and_env_vars(self):
             local_node_port,
             max_tag_value_length,
             timeout_param,
+            session_param,
         )
 
         self.assertIsInstance(exporter.encoder, ProtobufEncoder)
+        self.assertIsInstance(exporter.session, requests.Session)
         self.assertEqual(exporter.endpoint, constructor_param_endpoint)
         self.assertEqual(exporter.local_node.service_name, TEST_SERVICE_NAME)
         self.assertEqual(