-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending SQLCommenter support of dbapi into psycopg2 #940
Extending SQLCommenter support of dbapi into psycopg2 #940
Conversation
…n-v2' into sqlcommenter-psycopg2-integration-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thiyagu55 Can you add a test for this
|
A test case for this change can be very simple, making sure the default value is |
And you can add some integration tests here enabling this feature. |
…n-v2' into sqlcommenter-psycopg2-integration-v2
…n-v2' into sqlcommenter-psycopg2-integration-v2
@srikanthccv @ocelotl Unit tests and integration tests have been added and PR description is updated |
@Thiyagu55 Please fix the failing tests |
bad6b36
to
36737e4
Compare
Description
This PR integrates SQLCommenter into Psycopg2. When SQLCommenter is enabled in the library the SQL query logs will have traceparent id appended.
It's enabled using flag enable_commenter
Psycopg2Instrumentor()._instrument(tracer_provider=provider, enable_commenter=True)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.