Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlcommenter integration into SQLAlchemy #924

Merged
merged 24 commits into from
Mar 9, 2022
Merged

Sqlcommenter integration into SQLAlchemy #924

merged 24 commits into from
Mar 9, 2022

Conversation

Thiyagu55
Copy link
Contributor

@Thiyagu55 Thiyagu55 commented Feb 16, 2022 •
edited
Loading

Description

This PR integrates SQLCommenter into SQLAlchemy. When SQLCommenter is enabled in the library the query logs will have traceparent id appended

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The test cases are tested using the below commands
tox -e py39-test-instrumentation-sqlalchemy14 & tox -e py39-test-instrumentation-sqlalchemy14
`

Unit Testcases has been added

  • test_sqlcommenter_enabled
  • test_sqlcommenter_disabled
  • test_generate_commenter

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Thiyagu55 Thiyagu55 requested a review from a team February 16, 2022 13:22
@Thiyagu55 Thiyagu55 marked this pull request as draft February 16, 2022 13:23
@Thiyagu55 Thiyagu55 changed the title Sqlcommenter psycopg2 integration Sqlcommenter integration into SQLAlchemy Feb 16, 2022
sjs994
sjs994 reviewed Feb 16, 2022
View reviewed changes
Copy link

@sjs994 sjs994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thiyagu55

...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py Outdated Show resolved Hide resolved
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py Show resolved Hide resolved
@Thiyagu55 Thiyagu55 marked this pull request as ready for review February 23, 2022 11:19
srikanthccv
srikanthccv approved these changes Feb 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
srikanthccv
srikanthccv approved these changes Mar 2, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ocelotl ocelotl merged commit dbb35a2 into open-telemetry:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

@sjs994 sjs994 sjs994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thiyagu55 @sjs994 @lzchen @srikanthccv @ocelotl