Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging as a required package for pika instrumentation #882

Merged

Conversation

phillipuniverse
Copy link
Contributor

Fixes #881

Description

#881
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

In my project I added the packaging dependency and it resolved the issue detailed in #881.

  • Test A

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added n/a
  • Documentation has been updated n/a

@phillipuniverse phillipuniverse requested a review from a team January 28, 2022 00:50
@github-actions github-actions bot requested review from nikosokolik and oxeye-nikolay and removed request for a team January 28, 2022 00:50
Copy link

@nikosokolik nikosokolik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@owais owais merged commit e53c1da into open-telemetry:main Jan 28, 2022
@phillipuniverse phillipuniverse deleted the pika-packaging-transitive branch January 28, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Pika 0.28b0 instrumentation requires packaging, not declared in transitive dependencies
4 participants