Use Py Version and Package matrix to distinguish benchmarks #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
added
the
Skip Changelog
NathanielRN
commented
Dec 23, 2021
| combine-benchmarks: | ||
| runs-on: ubuntu-latest | ||
| needs: build | ||
| if: ${{ always() }} | ||
| name: Combine benchmarks from previous build job | ||
| strategy: | ||
| max-parallel: 1 |
There was a problem hiding this comment.
We run serially because the github-action-benchmark GH action takes a lock on the gh-pages branch.
NathanielRN
changed the title
|
Closing this PR for now since I'm not actively working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #838, the benchmark-action requires you provide the
nameunder which all the benchmarks should be uploaded. Because we merged all the benchmarks into one, it was combining all the benchmarks under the same name instead of distinguishing bymatrix.python-versionandmatrix.package.i.e.
py7 - sdkextensionpy8 - sdkextensionpy7 - propagatorwere all going under the same name, with the last
{pyversion} - {package}overwriting the previous one.To fix this we upload files that use
matrix.python-versionandmatrix.packageas the key for file naming.NOTE: This means we will have MANY more jobs because there will be a job for every
(matrix.python-version, matrix.package)permutation.QUESTION: Should we just combine everything under the same name (i.e.
OpenTelemetry Python Contrib Benchmarks) so we can do it all in one job?Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Didn't have a chance to run on my fork, but this is all on the
gh-pagesbranch which should be easy to clean up.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [] Changelogs have been updated- [] Unit tests have been added- [] Documentation has been updated