Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation meta package #516

Closed
wants to merge 5 commits into from
Closed

Conversation

owais
Copy link
Contributor

@owais owais commented May 26, 2021

Description

Add a new opentelemetry-instrumentation-all metapackage that does not ship any code but pulls in all instrumentations maintained by us.

Depends on #514

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais changed the title Meta packages Instrumentation meta package May 26, 2021
@owais owais force-pushed the meta-packages branch 2 times, most recently from 6e89801 to d685381 Compare May 27, 2021 02:46
@owais
Copy link
Contributor Author

owais commented May 27, 2021

Review after #475 and #514 are merged as this will get much smaller after rebase.

@owais owais marked this pull request as ready for review May 27, 2021 02:49
@owais owais requested review from a team, aabmass and srikanthccv and removed request for a team May 27, 2021 02:49
@owais owais marked this pull request as draft May 27, 2021 03:04
owais added 4 commits May 27, 2021 12:11
- We now automatically generate bootstrap_gen.py file from the list of instrumentations present in the source tree.
- Bootstrap command now uses consumes this auto-generated list instead of keeping it's own local copy.
- We no longer uninstall packages before installing them as instrumentation package no longer specify libraries as dependencies so the edge cases are no longer there.
- We no longer try to install an incompatible version or force upgrade/downgrade an installed version. This used to leave systems in broken states which should happen no more.
- We now automatically generate bootstrap_gen.py file from the list of instrumentations present in the source tree.
- Bootstrap command now uses consumes this auto-generated list instead of keeping it's own local copy.
- We no longer uninstall packages before installing them as instrumentation package no longer specify libraries as dependencies so the edge cases are no longer there.
- We no longer try to install an incompatible version or force upgrade/downgrade an installed version. This used to leave systems in broken states which should happen no more.
@owais
Copy link
Contributor Author

owais commented Sep 14, 2021

Closing in favor of #681

@owais owais deleted the meta-packages branch January 26, 2022 08:23
@owais owais restored the meta-packages branch January 26, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant