Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to projects #413

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Conversation

cynthiakedu
Copy link
Contributor

@cynthiakedu cynthiakedu commented Apr 5, 2021

Fixes broken links to project in a few READMEs, closes #323.

@cynthiakedu cynthiakedu marked this pull request as ready for review April 5, 2021 17:41
@cynthiakedu cynthiakedu requested review from a team, owais and hectorhdzg and removed request for a team April 5, 2021 17:41
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing these, happy to review once its out of draft

@owais
Copy link
Contributor

owais commented Apr 5, 2021

Thanks. Would be great to have the same thing for the metrics branch as well. It'd be more useful there as people can discover the source more easily from pypi

@cynthiakedu
Copy link
Contributor Author

Is the best way to do that just to create another PR? (and also assuming that I need to change the CHANGELOG PR number?)

@owais
Copy link
Contributor

owais commented Apr 5, 2021

@cynthiakedu Yes, another PR for that makes sense if you want to take that on. Thanks

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the branch and we can merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to project in a few READMEs
3 participants