Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency #358

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Add missing dependency #358

merged 2 commits into from
Mar 3, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Mar 2, 2021

Description

Add wrapt for the gRPC instrumentation

Fixes #357

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 2, 2021
@ocelotl ocelotl requested a review from a team March 2, 2021 23:54
@ocelotl ocelotl self-assigned this Mar 2, 2021
@ocelotl ocelotl requested review from codeboten and lzchen and removed request for a team March 2, 2021 23:54
@@ -42,6 +42,7 @@ install_requires =
opentelemetry-api == 1.0.0.dev0
opentelemetry-sdk == 1.0.0.dev0
grpcio ~= 1.27
wrapt >= 1.0.0, < 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ~= 1.0?
It should be noted that 2.0.0rc1 would fit the < 2.0.0 requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that 2.0.0rc1 would fit the < 2.0.0 requirement.

That's a bit surprising to me but in any case, wouldn't that only be the case if --pre is used with pip install? Not advocating for one way to specify deps. Just curious about how it works exactly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP-444 says:

The exclusive ordered comparison <V MUST NOT allow a pre-release of the specified version unless the specified version is itself a pre-release. Allowing pre-releases that are earlier than, but not equal to a specific pre-release may be accomplished by using <V.rc1 or similar.

So you're right, but I'm now wondering why this has failed so much for me in the past? I've definitely released broken versions into production because an alpha version got dragged by a "less than the next major" requirement spec, and I've never used --pre. Strange.

@lzchen lzchen merged commit aa31e73 into open-telemetry:main Mar 3, 2021
@ocelotl ocelotl deleted the issue_357 branch March 3, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC instrumentation is missing wrapt
5 participants