-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB-API: db.statement inclusion of sqlcomment as opt-in #3115
Merged
lzchen
merged 10 commits into
open-telemetry:main
from
tammy-baylis-swi:dbapi-db-statement-comment-opt-in
Jan 9, 2025
Merged
DB-API: db.statement inclusion of sqlcomment as opt-in #3115
lzchen
merged 10 commits into
open-telemetry:main
from
tammy-baylis-swi:dbapi-db-statement-comment-opt-in
Jan 9, 2025
+479
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
10 tasks
@alexmojaki PTAL |
alexmojaki
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
xrmx
approved these changes
Jan 9, 2025
11 tasks
lzchen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports new, optional kwarg
enable_attribute_commenter
at DB-API integration to opt intodb.statement
span attribute inclusion of sqlcomment.Partially addresses #3107
Is required to update driver-level instrumentors like psycopg2, mysqlclient, etc in this PR: #3121
Type of change
Breaking because
db.statement
span attribute inclusion of sqlcomment currently always happens if sqlcommenter enabled. It'll be opt-in with this update, so might break for those users relying on the feature introduced in 0.50b0, for instrumentation of any of psycopg2, psycopg, mysqlclient, PyMySQL. Those instrumentors will be updated in this PR: #3121How Has This Been Tested?
tox -e py312-test-instrumentation-dbapi
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.