Add type hints to Redis #3110
Merged
Add type hints to Redis #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a pylint failure here |
Kludex
force-pushed
the
type-hints-to-redis
branch
from
97db5cb to
186b3ec
Compare
fixed 👀 👍 |
emdneto
approved these changes
Dec 17, 2024
lzchen
added a commit
that referenced
this pull request
Dec 18, 2024
Followup to #3110 I believe [Pep 0604](https://peps.python.org/pep-0604/) which introduces union typing syntax is only supported for Python 3.10+. Since all instrumentations still support 3.8+, I believe we still need to adhere to the explicit `Optional` and `Union` typings.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.