Add type hints to Starlette instrumentation #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Nov 25, 2024
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Show resolved
Hide resolved
...mentation/opentelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/py.typed
Outdated
Show resolved
Hide resolved
|
Who are the 2 people I can ping to review my PRs? 👀 |
Viicos
reviewed
Nov 25, 2024
...ntelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/__init__.py
Outdated
Show resolved
Hide resolved
|
Is there a way we can more faster? It's only typing... And I maintain the package that is being instrumented... |
|
Docs CI is failing -- hopefully #3055 can solve it |
xrmx
approved these changes
Dec 2, 2024
emdneto
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can I set
line-lengthto 120 on ruff? This project is very verbosed, and the pre-commit is pushing it to 88, but 88 is not much for this project.Maintainer of Starlette here.