Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(httpx): check if mount transport is None before wrap #3022

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Nov 18, 2024

Description

Fixes #3020

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto requested a review from a team as a code owner November 18, 2024 22:35
@emdneto emdneto changed the title fix: check if mount transport is None before wrap fix(httpx): check if mount transport is None before wrap Nov 18, 2024
Signed-off-by: emdneto <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lzchen lzchen merged commit 19a59e4 into open-telemetry:main Nov 19, 2024
566 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPXClientInstrumentor.instrument_client fails when NO_PROXY is set
5 participants