Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.28.x-0.49bx] opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again (#3003) #3008

Merged

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Nov 15, 2024

Clean cherry-pick of #3003 to the release/v1.28.x-0.49bx branch.

Part of open-telemetry/opentelemetry-python#4281

xrmx and others added 2 commits November 15, 2024 02:59
…ethod again (open-telemetry#3003)

* opentelemetry-instrumentation-httpx: make instrument_client a staticmethod again

* ADd changelog

* Can be a classmethod

---------

Co-authored-by: Leighton Chen <[email protected]>
@aabmass aabmass added the Skip generate-workflows To be used for release PRs label Nov 15, 2024
@aabmass aabmass requested a review from a team as a code owner November 15, 2024 03:04
@aabmass
Copy link
Member Author

aabmass commented Nov 15, 2024

Misc 0 / docs (pull_request) Failing after 35s

Docs build is failing because of a limitation with our automation. I am going to ignore for this release branch since it is usually skipped in the cherry pick workflow run by opentelemetrybot

@aabmass aabmass merged commit 10b23cd into open-telemetry:release/v1.28.x-0.49bx Nov 15, 2024
540 of 541 checks passed
@aabmass aabmass deleted the cherrypick-3003 branch November 15, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip generate-workflows To be used for release PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants