Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop selective enabled for windows and regenerate workflows #2964

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Nov 6, 2024

Description

Selective enablement on windows testing broke core that is testing everything on windows :)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e generate_workflows

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner November 6, 2024 16:14
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 6, 2024
@xrmx xrmx marked this pull request as draft November 6, 2024 16:19
@xrmx xrmx force-pushed the revert-windows-testing branch from 609ea35 to 71de280 Compare November 6, 2024 16:28
@xrmx xrmx marked this pull request as ready for review November 6, 2024 16:29
@xrmx xrmx merged commit 77613da into open-telemetry:main Nov 6, 2024
536 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants