Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test packages that are released individually with lowest versions they support #2961

Merged

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 5, 2024

Description

We are currently testing packages that are released individually with the latest API , SDK and otel-instrumentation. But they list lower versions in their project.toml.

As a result, we don't catch when project.toml goes out of sync with the code. And we don't auto-update dependencies for them.

This PR fixes this:

  • it moves specific api/sdk/etc versions into test-requirements for packages that are released individually
  • removes a step that installs latest api/sdk/etc before testing
  • updates versions in project.toml which went out of sync (so that tests pass)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

tox.ini Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the test-packages-with-non-current-versions branch from ac85e05 to 4ba52ac Compare November 5, 2024 23:45
@lmolkova
Copy link
Contributor Author

lmolkova commented Nov 6, 2024

I think CI failures are coming from open-telemetry/opentelemetry-python#4245 which is not merged yet

tox.ini Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the test-packages-with-non-current-versions branch from c6a256e to 5a1c4dc Compare November 6, 2024 02:43
tox.ini Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the test-packages-with-non-current-versions branch from 324f663 to 3f2574b Compare November 6, 2024 17:19
@lmolkova lmolkova force-pushed the test-packages-with-non-current-versions branch from 48cd6ad to 3f2574b Compare November 7, 2024 17:29
@lzchen lzchen merged commit 499548e into open-telemetry:main Nov 7, 2024
1119 checks passed
lmolkova added a commit to lmolkova/opentelemetry-python-contrib that referenced this pull request Nov 7, 2024
@lmolkova lmolkova deleted the test-packages-with-non-current-versions branch November 7, 2024 20:31
lmolkova added a commit to lmolkova/opentelemetry-python-contrib that referenced this pull request Nov 7, 2024
lmolkova added a commit to lmolkova/opentelemetry-python-contrib that referenced this pull request Nov 7, 2024
lzchen pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants