datadog-exporter: bugfix for unintentional type change #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alertedsnake
requested review from
a team,
owais and
ocelotl
and removed request for
a team
Using `|=` here makes `trace_flags` into an int, rather than a
`TraceFlags` object:
```
>>> import opentelemetry.trace as trace
>>> f = trace.TraceFlags()
>>> type(f)
<class 'opentelemetry.trace.span.TraceFlags'>
>>> f |= trace.TraceFlags.SAMPLED
>>> type(f)
<class 'int'>
```
This fix will preserve the type.
You may ask, but where's the sample code to demostrate the bug? I'm in
the middle of trying to debug a number of odd issues with the gRPC
client interceptor, so it's a bit convoluted, but it looks like this:
```
Traceback (most recent call last):
File "/home/michael/work/myapp/.venv/lib/python3.8/site-packages/grpc/_server.py", line 435, in _call_behavior
response_or_iterator = behavior(argument, context)
File "/home/michael/xfer/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py", line 252, in telemetry_interceptor
with self._start_span(
File "/home/michael/xfer/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py", line 232, in _start_span
return self._tracer.start_as_current_span(
File "/home/michael/xfer/opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py", line 756, in start_as_current_span
span = self.start_span(
File "/home/michael/xfer/opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py", line 807, in start_span
sampling_result = self.sampler.should_sample(
File "/home/michael/xfer/opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py", line 273, in should_sample
if parent_span_context.trace_flags.sampled:
AttributeError: 'int' object has no attribute 'sampled'
```
alertedsnake
force-pushed
the
fix-datadog-bug
branch
from
2c6e52d to
2de9466
Compare
lzchen
approved these changes
Jan 5, 2021
codeboten
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
|=here makestrace_flagsinto an int, rather than aTraceFlagsobject:This fix will preserve the type. I assume this is desired - can't see why it wouldn't be, but I'm still a bit new to this stack, so confirmation would be welcome.
You may ask, but where's the sample code to demonstrate the bug? I'm in the middle of trying to debug a number of odd issues with the gRPC client interceptor when used with Datadog, so it's a bit convoluted - essentially I'm making a gRPC request to one service which makes a gRPC request to another. When the Datadog exporter is enabled, I get a traceback like this:
If I switch to the Jaeger exporter rather than Datadog, my code runs perfectly fine.
If I remove this code from my primary service, it also runs fine:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The best way is to just look at what the code does in the console.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.