datadog-exporter: bugfix for unintentional type change #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
|=
here makestrace_flags
into an int, rather than aTraceFlags
object:This fix will preserve the type. I assume this is desired - can't see why it wouldn't be, but I'm still a bit new to this stack, so confirmation would be welcome.
You may ask, but where's the sample code to demonstrate the bug? I'm in the middle of trying to debug a number of odd issues with the gRPC client interceptor when used with Datadog, so it's a bit convoluted - essentially I'm making a gRPC request to one service which makes a gRPC request to another. When the Datadog exporter is enabled, I get a traceback like this:
If I switch to the Jaeger exporter rather than Datadog, my code runs perfectly fine.
If I remove this code from my primary service, it also runs fine:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
The best way is to just look at what the code does in the console.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.