Fixing w3c baggage support in opentelemetry-instrumentation-aws-lambda #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
...elemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py
Show resolved
Hide resolved
...ion/opentelemetry-instrumentation-aws-lambda/tests/test_aws_lambda_instrumentation_manual.py
Outdated
Show resolved
Hide resolved
pmcollins
reviewed
Jun 28, 2024
...elemetry-instrumentation-aws-lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py
Outdated
Show resolved
Hide resolved
|
@dtorok please rebase and move the CHANGELOG entry to a new unreleased section |
dtorok
force-pushed
the
aws-lambda-baggage-support
branch
from
c25ef63 to
bc1cbbc
Compare
xrmx
approved these changes
Jul 30, 2024
tammy-baylis-swi
approved these changes
Jul 30, 2024
ocelotl
force-pushed
the
aws-lambda-baggage-support
branch
from
bc1cbbc to
6c93900
Compare
6 tasks
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
open-telemetry#2589) * Fixing w3c baggage support in opentelemetry-instrumentation-aws-lambda * Changelog update * Passing context not needed * Fixing unit test after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing baggage support in
opentelemetry-instrumentation-aws-lambdapackage.After determining the parent context (
_determine_parent_context()), it was only used to create the wrapper span, but wasn't attached to the global context. Although thestart_as_current_span()call attaches the span's context, but because theSpanContextonly contains span-related info, the baggage content was lost, and the propagators couldn't pick it up.This change attaches/detaches the baggage to the context in a
try/finallyclause. Other instrumentations do the same either directly, or through_start_internal_or_server_span().Type of change
How Has This Been Tested?
Implemented a unit test, and ran all the relevant tests:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.