Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed labels from system-metrics #1570

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −28
Draft

Removed labels from system-metrics #1570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions ...strumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,38 +119,11 @@ def __init__(
self._config = _DEFAULT_CONFIG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original attribute labels defined in line 114 is still needed?

also, these deleted labels are used later on in this file, inside the functions, should they be deleted as well?

else:
self._config = config
self._labels = {} if labels is None else labels
self._meter = None
self._python_implementation = python_implementation().lower()

self._proc = psutil.Process(os.getpid())

self._system_cpu_time_labels = self._labels.copy()
self._system_cpu_utilization_labels = self._labels.copy()

self._system_memory_usage_labels = self._labels.copy()
self._system_memory_utilization_labels = self._labels.copy()

self._system_swap_usage_labels = self._labels.copy()
self._system_swap_utilization_labels = self._labels.copy()

self._system_disk_io_labels = self._labels.copy()
self._system_disk_operations_labels = self._labels.copy()
self._system_disk_time_labels = self._labels.copy()
self._system_disk_merged_labels = self._labels.copy()

self._system_network_dropped_packets_labels = self._labels.copy()
self._system_network_packets_labels = self._labels.copy()
self._system_network_errors_labels = self._labels.copy()
self._system_network_io_labels = self._labels.copy()
self._system_network_connections_labels = self._labels.copy()

self._system_thread_count_labels = self._labels.copy()

self._runtime_memory_labels = self._labels.copy()
self._runtime_cpu_time_labels = self._labels.copy()
self._runtime_gc_count_labels = self._labels.copy()


def instrumentation_dependencies(self) -> Collection[str]:
return _instruments

Expand Down