-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBAPI: Add param to control capturing of db.statement.parameters #156
DBAPI: Add param to control capturing of db.statement.parameters #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small changes, but LGTM!
instrumentation/opentelemetry-instrumentation-dbapi/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yusuke Tsutsumi <[email protected]>
@@ -16,7 +19,7 @@ Released 2020-09-17 | |||
Released 2020-08-14 | |||
|
|||
- Change package name to opentelemetry-instrumentation-dbapi | |||
([#966](https://github.com/open-telemetry/opentelemetry-python/pull/966)) | |||
([#156](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/156)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh... not sure what I was thinking. Will fix this.
Description
Switched DBAPI so that it will not capture parameterized query parameters. Capturing this would be a problem in production environments since they will contain sensitive information such as session tokens and hashed passwords.
Have added a parameter to the instrumentation constructor to allow for this feature to be turned on.
I will mark this as a breaking change since I am removing the db.statement.parameter span attribute and something might be depending on it.
Fixes #157
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: