Urllib3 instrumentation can now retrieve urlopen body parameter when … #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra17
force-pushed
the
isra/load-positional-body-in-urlopen
branch
from
f1fad00 to
1b47344
Compare
srikanthccv
approved these changes
Oct 23, 2022
|
Please resolve conflicts. This is simple change that is ready to be merged. |
…used as positional
isra17
force-pushed
the
isra/load-positional-body-in-urlopen
branch
from
1b47344 to
55db1ee
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load
bodyfromurlopenhook when it's being pass as a positional parameter.How Has This Been Tested?
tox -e test-instrumentation-urllib3