collect threads count in opentelemetry-instrumentation-system-metrics #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yulin-li
force-pushed
the
yulin/threading
branch
from
2ca7ab9 to
6f6028a
Compare
ocelotl
reviewed
Sep 27, 2022
will do |
ut added, pls help to review |
ocelotl
approved these changes
Sep 28, 2022
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
…open-telemetry#1339) * collect threads count in opentelemetry-instrumentation-system-metrics * update * avoid devidedByZero exception when sawp memory is 0 * add ut * change log * lint * lint Co-authored-by: Srikanth Chekuri <[email protected]>
saartochner-lumigo
pushed a commit
to lumigo-io/opentelemetry-python-contrib
that referenced
this pull request
Nov 13, 2022
…open-telemetry#1339) * collect threads count in opentelemetry-instrumentation-system-metrics * update * avoid devidedByZero exception when sawp memory is 0 * add ut * change log * lint * lint Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Active threads count is a valuable metric and we can expose it in
opentelemetry-instrumentation-system-metrics.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tests/test_system_metrics.py::TestSystemMetrics::test_system_thread_countDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.