-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multiple db connections support for django-instrumentation's sqlcommenter #1187
Adding multiple db connections support for django-instrumentation's sqlcommenter #1187
Conversation
…on' into django-sqlcommenter-multiconection
@srikanthccv for your notice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Please make the sqlcommenter specific utils private.
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Outdated
Show resolved
Hide resolved
…on' into django-sqlcommenter-multiconection
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py
Outdated
Show resolved
Hide resolved
@srikanthccv Please mark it as approved after the requested changes are in to avoid accidental merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking to prevent accidental merge. @Thiyagu55 please make the functions private since they are not user facing.
…on' into django-sqlcommenter-multiconection
Multiple DB Connection support for sqlcommenter django-instrumetation
Opentelemetry-instrumentation-django's sqlcommenter will now be able to support multiple database connections.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit test has been added named test_multiple_connection_support
Checklist: