-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span for connection phase #1134
Add span for connection phase #1134
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! We need at least one test case that validates these changes are correct 🙂
@ocelotl no problem!
Can you guide me through an example? You mean UT? Also, I saw that some tests are failing now so I'll fix it |
@ocelotl Fixed all tests and they pass now. Also - they're covering the connect phase, as every test use |
@ocelotl |
you probably wanted to add listen on connect similar to this Lines 87 to 91 in 80969a0
|
@srikanthccv So - initially, I thought about this approach too. Still, the problem is that if I add a listener to the Unfortunately, |
@shahargl makes sense |
…/opentelemetry-python-contrib into feature/sqlalchemy-connect-span
@ocelotl updated the code to allow SQLAlchemy 1.1 too |
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Outdated
Show resolved
Hide resolved
…pentelemetry/instrumentation/sqlalchemy/engine.py Co-authored-by: Srikanth Chekuri <[email protected]>
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Outdated
Show resolved
Hide resolved
…pentelemetry/instrumentation/sqlalchemy/engine.py Co-authored-by: Srikanth Chekuri <[email protected]>
instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py
Outdated
Show resolved
Hide resolved
@ocelotl @srikanthccv - fixed the tests :) feel free to approve/merge |
I see some tests failing, please take a look, @shahargl |
…/opentelemetry-python-contrib into feature/sqlalchemy-connect-span
@ocelotl fixed, can you report the status so the tests will run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comments.
instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.py
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py
Show resolved
Hide resolved
…/opentelemetry-python-contrib into feature/sqlalchemy-connect-span
@ocelotl |
@ocelotl
So idk why, do you have idea? Also, fixed the |
Description
I've added the code that adds #1133
Fixes #1133
#1133
Type of change
Please delete options that are not relevant.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.